[PATCH] D60226: [ThinLTO] Fix ThinLTOCodegenerator to export llvm.used symbols

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

Just noticed something else looking through it again, question below.



================
Comment at: llvm/include/llvm/LTO/legacy/ThinLTOCodeGenerator.h:254
    */
-  void promote(Module &Module, ModuleSummaryIndex &Index);
+  void promote(Module &Module, ModuleSummaryIndex &Index,
+               const lto::InputFile *File = nullptr);
----------------
This and the functions below take an InputFile pointer with a nullptr default - why the default (and null check in these routines), since it looks like it is always being passed (other than emitImports, note on that further down). Can you remove the default parameter value, and also make this take a reference and remove the null checks?


================
Comment at: llvm/tools/llvm-lto/llvm-lto.cpp:626
+          getThinLTOOutputFile(OutputName, OldPrefix, NewPrefix);
       ThinGenerator.emitImports(*TheModule, OutputName, *Index);
     }
----------------
This should now pass Input.get()


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60226/new/

https://reviews.llvm.org/D60226