[PATCH] D60347: [TSan][libdispatch] Replace CFRunLoop with barriers, pt. 1

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 5 17:10:58 PDT 2019


kubamracek added a comment.

General point: Should we actually be using the TSan-invisible barrier for this purpose? Maybe a "normal" primitive, like a dispatch semaphore would make this more clear that we're just trying to tell the main thread that we're done.



================
Comment at: compiler-rt/test/tsan/Darwin/gcd-after.mm:2
+// RUN: %clang_tsan %s -o %t
+// RUN: %run %t 2>&1 | FileCheck %s --implicit-check-not='ThreadSanitizer'
 
----------------
Please make this change separately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60347/new/

https://reviews.llvm.org/D60347





More information about the llvm-commits mailing list