[PATCH] D60331: [gn] Support for building compiler-rt builtins

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 5 13:06:53 PDT 2019


thakis added inline comments.


================
Comment at: compiler-rt/lib/builtins/CMakeLists.txt:154
+  umodti3.c
+)
 
----------------
phosek wrote:
> thakis wrote:
> > (the more common style is to indent the ) by two. unless you're being consistent with other places in this file, consider indenting the closing parens)
> Other `set`s in this file already used this style so I was trying to be consistent with those. Do you want me to reformat all of them?
No, it's fine then.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60331/new/

https://reviews.llvm.org/D60331





More information about the llvm-commits mailing list