[PATCH] D59942: [DebugInfo] Track multiple registers in DbgEntityHistoryCalculator

Fri Apr 5 08:55:19 PDT 2019

dstenb marked an inline comment as done.
dstenb added a comment.

Thanks for the review! Just so that I don't misunderstand something; is the LGTM specifically for the changes in this patch, or does that imply the entire patch series?

================
Comment at: lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp:161
   if (HistMap.startDbgValue(Var, DV, NewIndex)) {
+    DenseMap<unsigned, bool> TrackedRegs;
+
----------------
aprantl wrote:
> dstenb wrote:
> > aprantl wrote:
> > > Should this be a SmallDenseMap?
> > Sorry, yes, this was totally overkill. For example, in a RelWithDebInfo+asan build the maximum size of the map was 11, and in 99.98% of the cases the size of the map was less than or equal 2.
> So should it be size 2 then? ;-)
Right! I'll change that.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59942/new/

https://reviews.llvm.org/D59942