[PATCH] D60312: [llvm-readobj] Add GNU style dumper for .gnu.version_d section

Fri Apr 5 03:15:41 PDT 2019

Higuoxing planned changes to this revision.
Higuoxing marked an inline comment as done.
Higuoxing added inline comments.

================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:3417

+  const uint8_t *SecStartAddress =
+      reinterpret_cast<const uint8_t *>(Obj->base() + Sec->sh_offset);
----------------
jhenderson wrote:
> Higuoxing wrote:
> > jhenderson wrote:
> > > Given that much of this code is a copy of the LLVMStyle, that indicates that it should be shared somehow. I don't know if in this file, or in the Object library somewhere makes sense, but I think the only distinction should be how to print the output.
> > Yes, I agree. I would like to improve this in the future.
> I don't think we should delay it to the future. It should be done either as part of, or more likely prior to this patch.
Sure, I will do that first. Thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60312/new/

https://reviews.llvm.org/D60312