[PATCH] D60275: [RFC] IR extensions for annotating directive region entry/exit with a set of OpBundle name definitions for OpenMP

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

This looks partial

- no langref changes
- `INTEL_COLLAB` is not a cmake option, and is not set in config.h - how it's supposed to function? is it supposed to stay?



================
Comment at: llvm/include/llvm/IR/CMakeLists.txt:9-11
+set(LLVM_TARGET_DEFINITIONS Intel_Directives.td)
+tablegen(LLVM Intel_Directives.gen -gen-directives)
+add_public_tablegen_target(intel_directives_gen)
----------------
tabulate


================
Comment at: llvm/include/llvm/IR/Intel_Directives.td:1
+// INTEL_COLLAB   -*- tablegen -*-
+//==- Intel_Directives.td - Defines all parallelization and -*- tablegen -*-==//
----------------
license blurb is not in line with other files.


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:942
+// end INTEL_COLLAB
 //===------------------------ Coroutine Intrinsics ---------------===//
 // These are documented in docs/Coroutines.rst
----------------
newline


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:1073
+// INTEL_COLLAB
+// These intrinsics will be deprecated.
+// Use int_directive_region_entry/exit instead.
----------------
I don't think there is anything in llvm that uses these?
I wouldn't think a new stuff should be added that is already deprecated from get-go?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60275/new/

https://reviews.llvm.org/D60275