[PATCH] D60081: [COFF] Fix delay import directory iterator

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Generally looking good, but I'd make the test files smaller.



================
Comment at: lld/test/COFF/Inputs/delayimporttables-alpha.yaml:10-33
+  - Name:            '.debug$S'
+    Characteristics: [ IMAGE_SCN_CNT_INITIALIZED_DATA, IMAGE_SCN_MEM_DISCARDABLE, IMAGE_SCN_MEM_READ ]
+    Alignment:       1
+    SectionData:     04000000F1000000670000002900011100000000443A5C536372617463685C726561646F626A2D726570726F5C416C7068612E6F626A003A003C1100620000D000130010009369010013001000936901004D6963726F736F667420285229204F7074696D697A696E6720436F6D70696C65720000
+    Subsections:
+      - !Symbols
+        Records:
----------------
Remove this section.


================
Comment at: lld/test/COFF/Inputs/delayimporttables-alpha.yaml:38-40
+  - Name:            .chks64
+    Characteristics: [ IMAGE_SCN_LNK_INFO, IMAGE_SCN_LNK_REMOVE ]
+    SectionData:     542F239133C7DB75C11D578BC4A1E02E6E3900D26CEA22270000000000000000
----------------
Remove this section.


================
Comment at: lld/test/COFF/Inputs/delayimporttables-alpha.yaml:42-53
+  - Name:            '@comp.id'
+    Value:           17066387
+    SectionNumber:   -1
+    SimpleType:      IMAGE_SYM_TYPE_NULL
+    ComplexType:     IMAGE_SYM_DTYPE_NULL
+    StorageClass:    IMAGE_SYM_CLASS_STATIC
+  - Name:            '@feat.00'
----------------
These symbols can be removed.


================
Comment at: lld/test/COFF/Inputs/delayimporttables-alpha.yaml:66-77
+  - Name:            '.debug$S'
+    Value:           0
+    SectionNumber:   2
+    SimpleType:      IMAGE_SYM_TYPE_NULL
+    ComplexType:     IMAGE_SYM_DTYPE_NULL
+    StorageClass:    IMAGE_SYM_CLASS_STATIC
+    SectionDefinition:
----------------
This can be removed.


================
Comment at: lld/test/COFF/Inputs/delayimporttables-alpha.yaml:108-119
+  - Name:            .chks64
+    Value:           0
+    SectionNumber:   4
+    SimpleType:      IMAGE_SYM_TYPE_NULL
+    ComplexType:     IMAGE_SYM_DTYPE_NULL
+    StorageClass:    IMAGE_SYM_CLASS_STATIC
+    SectionDefinition:
----------------
I believe you don't need this symbol.


================
Comment at: lld/test/COFF/delayimporttables.test:1-3
+# RUN: yaml2obj %p/Inputs/delayimporttables-alpha.yaml > %t-alpha.obj
+# RUN: yaml2obj %p/Inputs/delayimporttables-beta.yaml > %t-beta.obj
+# RUN: yaml2obj %p/Inputs/delayimporttables-root.yaml > %t-root.obj
----------------
%t1, %t2, %t3 are more conventional than %t-alpha, beta, etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60081/new/

https://reviews.llvm.org/D60081