[PATCH] D60170: [llvm-objcopy] [llvm-symbolizer] Fix failing tests

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 3 15:35:09 PDT 2019


rupprecht added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/regex.test:50
 
-#REGEX1-NOT: foobaz
-#REGEX1-NOT: bar
-#REGEX1-NOT: rebar
+#REGEX1-NOT: Name: foobaz
+#REGEX1-NOT: Name: bar
----------------
These tests fails because the match is embedded in the filename depending on the username. So you can skip the filename by searching for "Symbols [", since FileCheck checks for things in order.

e.g.

```
# REGEX1:     Symbols [
# REGEX1-NOT:   Name: foobaz
# REGEX1-NOT:   Name: bar
# REGEX1-NOT:   Name: rebar
...
```

(It should even work without the `Name: ` part, but it's clearer to leave that in)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60170/new/

https://reviews.llvm.org/D60170





More information about the llvm-commits mailing list