[PATCH] D60133: [DAGCombiner] Improve detection of unmergable stores, based on type size (WIP)

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In D60133#1452430 <https://reviews.llvm.org/D60133#1452430>, @niravd wrote:

> It's not sufficient to check if you can merge two stores into a valid node; there are backends where you need 4 or more to get a legal merged store.
>
> If you look at target-specific implementations of CanMergeStoresTo it essentially serves as a context-specific find maximum store which is what we need here.  If you massage that interface a bit you can fold most of this check in there.


Yeah, that might be a better approach. IIUC we would need the (potentially separate) limits for integer types, floating point types and vector types. And accounting for when we can convert to vector types. Does that make sense?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60133/new/

https://reviews.llvm.org/D60133