[PATCH] D60122: [yaml2obj][obj2yaml] - Change how symbol's binding is descibed when parsing/dumping.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 3 05:02:39 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one minor comment.



================
Comment at: tools/yaml2obj/yaml2elf.cpp:324
 
+static size_t findLastLocal(ArrayRef<ELFYAML::Symbol> Symbols) {
+  for (size_t I = 0; I < Symbols.size(); ++I)
----------------
Sorry, actually, I think findFirstNonGlobal would be better, now that I think about it!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60122/new/

https://reviews.llvm.org/D60122





More information about the llvm-commits mailing list