[PATCH] D60041: [X86] Merge the different CMOV instructions for each condition code into single instructions that store the condition code as an immediate.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 3 03:15:16 PDT 2019


lebedev.ri added a comment.

In D60041#1452874 <https://reviews.llvm.org/D60041#1452874>, @courbet wrote:

> In D60041#1452858 <https://reviews.llvm.org/D60041#1452858>, @RKSimon wrote:
>
> > @lebedev.ri and @courbet Are you happy with this and D60138 <https://reviews.llvm.org/D60138>?
>
>
> Yes, a specific OPERAND_TYPE lets us handle this correctly, even there are still details that are currently being ironed out by @gchatelet and @lebedev.ri.


SGTM. I'm not sure these patches should wait for exegesis patches, because exegesis patches are certainly waiting for these patches :)
Things aren't great with modelling immediates already, so one more opcode won't really make things that much worse.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60041/new/

https://reviews.llvm.org/D60041





More information about the llvm-commits mailing list