[PATCH] D60131: [ELF] Change default output section type to SHT_PROGBITS

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In D60131#1451518 <https://reviews.llvm.org/D60131#1451518>, @andrewng wrote:

> I intend to fix the orphan behavior in a separate change, which is why it has been marked as XFAIL for now.


I am not sure we have the practice to disable the test cases. What do you think about uploading the fix for orphan behavior
in a separate change rebased on this patch too, so that these 2 patches can be reviewed together?
(in that case, having XFAIL here is fine I think).



================
Comment at: test/ELF/linkerscript/symbol-only-align.test:5
+# RUN: echo '.data'   >> %t.s
+# RUN: echo '.quad 0' >> %t.s
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %t.s -o %t.o
----------------
In LLD we avoid using multiple echo calls. Please do it with a single call.


================
Comment at: test/ELF/linkerscript/symbol-only-align.test:10
+
+PHDRS {
+  text PT_LOAD FLAGS(0x5);
----------------
Could you add a brief description of what this test does and what it checks here please?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60131/new/

https://reviews.llvm.org/D60131