[PATCH] D60147: [DWARF] check whether the DIE is valid before querying for information

[Paul Semel via Phabricator via llvm-commits]

paulsemel created this revision.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.

This prevents for having an assert instead of just returning an empty DIEsForAddress object.


Repository:
  rL LLVM

https://reviews.llvm.org/D60147

Files:
  llvm/lib/DebugInfo/DWARF/DWARFContext.cpp


Index: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
===================================================================
--- llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
+++ llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
@@ -925,6 +925,9 @@
     DWARFDie DIE = Worklist.back();
     Worklist.pop_back();
 
+    if (!DIE.isValid())
+      continue;
+
     if (DIE.getTag() == DW_TAG_lexical_block &&
         DIE.addressRangeContainsAddress(Address)) {
       Result.BlockDIE = DIE;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60147.193350.patch
Type: text/x-patch
Size: 470 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190402/69f67d3b/attachment.bin>