[PATCH] D60125: [ScheduleDAGRRList] Recompute topological ordering on demand.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp:1488
+  if (!Interferences.empty())
+    Topo.fixOrder();
   // All candidates are delayed due to live physical reg dependencies.
----------------
efriedma wrote:
> Where exactly do we query the topological order relative to this call to fixOrder()?  Do we need to fixOrder() inside the loop?
We only query it in the loop below (WillCreateCycle call). In case we add new predecessors, we also exit the loop. And we only enter the loop, if there are some interferences. Maybe it's worth adding a comment here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60125/new/

https://reviews.llvm.org/D60125