[PATCH] D60118: [AArch64][AsmParser] Fix .arch_extension directive parsing

[Cullen Rhodes via Phabricator via llvm-commits]

c-rhodes added a comment.

@SjoerdMeijer It appears the `.cpu`, `.arch` and `.arch_extension` directives can only enable features defined in `ExtensionMap` in the AArch64AsmParser.cpp and ignores them otherwise. `ExtensionMap` seems incomplete, in the patch you mentioned only `tlb-rmi`, `pan-rwv` and `ccpp` features were added. There's also a comment:

  2834     // FIXME: Unsupported extensions
  2835     {"pan", {}},
  2836     {"lor", {}},
  2837     {"rdma", {}},
  2838     {"profile", {}},

Which includes `pan` and `lor` which I don't understand why they are unsupported, perhaps they were added before the full feature support. I think additional work is required to improve `ExtensionMap`, I could add further tests for features currently available such as SVE in this patch, or is it also worth addressing the missing features?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60118/new/

https://reviews.llvm.org/D60118