[PATCH] D60124: gn build: Add build files for non-framework xpc clangd bits

[Nico Weber via Phabricator via llvm-commits]

thakis marked 2 inline comments as done.
thakis added inline comments.


================
Comment at: llvm/utils/gn/secondary/clang-tools-extra/clangd/xpc/BUILD.gn:17
+  configs += [ "//llvm/utils/gn/build:clang_code" ]
+  deps = [
+    "//clang-tools-extra/clangd",
----------------
mbonadei wrote:
> Missing ":conversions" in deps.
Thanks! Done.


================
Comment at: llvm/utils/gn/secondary/clang-tools-extra/clangd/xpc/enable.gni:3
+  # Whether to build clangd's XPC components.
+  clangd_build_xpc = current_os == "mac"
+}
----------------
mbonadei wrote:
> Is it ok to keep this ` = current_os == "mac"`, from the CL description I had the feeling that xpc tests were still disabled.
Yes, because clang-tools/extra/test/BUILD.gn still has `CLANGD_BUILD_XPC_SUPPORT=0`, so lit thinks xpc support isn't available and doesn't run the xpc lit tests. And the xpc unit tests pass, so they run after this change.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60124/new/

https://reviews.llvm.org/D60124