[PATCH] D60127: Declare library dependency introduced by https://reviews.llvm.org/D59482

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 2 06:56:38 PDT 2019


labath added a comment.

In D60127#1451391 <https://reviews.llvm.org/D60127#1451391>, @jhenderson wrote:

> My main concern is the number of files needed to build obj2yaml/yaml2obj, which would dramatically increase with that dependency. That being said, most of those files would be needed to be built for the tools that these two executables are used to test, so I don't think it's a genuine issue, and what you say about naturalness does make sense, so please go ahead and fix it.


Thanks. It looks like somebody already beat me to it (r357471).

I don't think this will have any affect on the dependency graph of these two tools, as they already have this dependency in their own CMakeLists.txt files. This makes total sense for obj2yaml, as it uses the object library to parse the object files. I'm not entirely sure why this is needed for yaml2obj, but the dependency seems to be coming from the wasm and coff code.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60127/new/

https://reviews.llvm.org/D60127





More information about the llvm-commits mailing list