[PATCH] D58427: Fix checking for rpc/xdr.h

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 1 23:25:37 PDT 2019


MaskRay added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_solaris.cc:31
 #include <pwd.h>
+#include <rpc/types.h>
 #include <rpc/xdr.h>
----------------
Are you sure Solaris needs this? This is contrary to my research.


================
Comment at: compiler-rt/test/msan/Linux/sunrpc.cc:17
 #include <assert.h>
+#include <rpc/types.h>
 #include <rpc/xdr.h>
----------------
Does Linux need this?


================
Comment at: compiler-rt/test/msan/Linux/sunrpc_bytes.cc:10
 #include <string.h>
+#include <rpc/types.h>
 #include <rpc/xdr.h>
----------------
Does Linux need this?


================
Comment at: compiler-rt/test/msan/Linux/sunrpc_string.cc:10
 #include <string.h>
+#include <rpc/types.h>
 #include <rpc/xdr.h>
----------------
Does Linux need this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58427/new/

https://reviews.llvm.org/D58427





More information about the llvm-commits mailing list