[PATCH] D60067: [llvm-symbolizer] Add llvm-addr2line.

Mon Apr 1 10:06:02 PDT 2019

rupprecht added a subscriber: Quolyk.
rupprecht added a reviewer: dblaikie.
rupprecht added a comment.

(adding a few others that may be interested)

================
Comment at: include/llvm/DebugInfo/Symbolize/DIPrinter.h:33
   bool Basenames;
+  bool OutputStyleGNU;

----------------
This should be the enum itself, not a bool

================
Comment at: lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp:230-231
+      shouldOverrideWithSymbolTable(FNKind, UseSymbolTable))
+    return symbolizeInlinedCode(ModuleOffset, FNKind, UseSymbolTable)
+        .getFrame(0);
+
----------------
I don't really understand this bit... would it make more sense to have this happen a level up? i.e. make the caller of this check UseSymbolTableForInlinedFunctions and call the right method instead?

================
Comment at: test/tools/llvm-symbolizer/addr2line.test:21
+NOINLINING-NOT: (inlined by)
\ No newline at end of file

----------------
nit: include a newline at the end

================
Comment at: tools/llvm-symbolizer/llvm-symbolizer.cpp:262
                                ClUseRelativeAddress, ClDefaultArch,
-                               ClFallbackDebugPath);
+                               ClFallbackDebugPath, !IsAddr2Line);

----------------
The parameter should be commented, i.e. `/*UseSymbolTableForInlinedFunctions=*/!IsAddr2Line`

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60067/new/

https://reviews.llvm.org/D60067