[PATCH] D56593: [SelectionDAG][RFC] Allow the user to specify a memeq function (v5).

Mon Apr 1 02:18:53 PDT 2019

courbet added a comment.

OK, I succeeded in profiling this using pprof instead of callgrind.

Again, before 356550 I see:

  210764079 32.23% 32.23%  210764079 32.23%  CStretchEngine::ContinueStretchHorz
    98749133 15.10% 47.33%   98749133 15.10%  (anonymous namespace)::FaxG4GetRow
    76895485 11.76% 59.09%   76895485 11.76%  <unknown>
    72290505 11.06% 70.15%   72290505 11.06%  (anonymous namespace)::FindBit
    24300088  3.72% 73.86%   24300088  3.72%  CFX_ScanlineCompositor::CompositeByteMaskLine
    21546869  3.30% 77.16%   21546869  3.30%  CStretchEngine::StretchVert
    17315093  2.65% 79.81%   17315093  2.65%  [pdfium_test]
    16493189  2.52% 82.33%   16493189  2.52%  __memcmp_sse4_1
     8353611  1.28% 83.61%    8353611  1.28%  CStretchEngine::CWeightTable::Calc
     7791739  1.19% 84.80%    7791739  1.19%  CPDF_DIBBase::TranslateScanline24bppDefaultDecode

and after the change:

  195287006 32.16% 32.16%  195287006 32.16%  CStretchEngine::ContinueStretchHorz
   85942976 14.15% 46.31%   85942976 14.15%  (anonymous namespace)::FaxG4GetRow
   75448209 12.42% 58.74%   75448209 12.42%  <unknown>
   64249874 10.58% 69.32%   64249874 10.58%  (anonymous namespace)::FindBit
   32990212  5.43% 74.75%   32990212  5.43%  CStretchEngine::StretchVert
   14766318  2.43% 77.18%   14766318  2.43%  CFX_ScanlineCompositor::CompositeByteMaskLine
   13827062  2.28% 79.46%   13827062  2.28%  [pdfium_test]
    9502572  1.56% 81.02%    9502572  1.56%  CPDF_DIBBase::TranslateScanline24bppDefaultDecode
    6078561  1.00% 82.02%    6078561  1.00%  CStretchEngine::CWeightTable::Calc
    5193562  0.86% 82.88%    5193562  0.86%  CPDF_TextPage::ProcessTextObject

So I'm now quite confident that de-inlining was the cause of the regression and that it was fixed by 356550.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56593/new/

https://reviews.llvm.org/D56593