[PATCH] D59986: [ELF] Respect NonAlloc when copying flags from the previous sections

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 1 02:00:52 PDT 2019


ruiu added inline comments.


================
Comment at: ELF/LinkerScript.cpp:883
     if (Sec->Live)
       Flags = Sec->Flags;
 
----------------
Sec->Flags can have  SHF_ALLOC bit on while Sec->NonAlloc is true? If so, it sounds like a contradiction... Maybe we should fix that?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59986/new/

https://reviews.llvm.org/D59986





More information about the llvm-commits mailing list