[PATCH] D59780: Support Intel Control-flow Enforcement Technology

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/Arch/X86.cpp:415
+namespace {
+class IntelCET : public X86 {
+public:
----------------
`IBT` (or `IBTPlt`) may be a better name than `IntelCET` as this class has nothing to do with the other part of CET: shstk.


================
Comment at: lld/test/ELF/Inputs/i386-cet1.s:2
+.section ".note.gnu.property", "a"
+.long 4
+.long 12
----------------
Missing `.align 4`


================
Comment at: lld/test/ELF/Inputs/i386-cet2.s:1
+.section ".note.gnu.property", "a"
+.long 4
----------------
Missing `.align 8`


================
Comment at: lld/test/ELF/Inputs/i386-cet4.s:1
+.section ".note.gnu.property", "a"
+.long 4
----------------
In one of the tests, it may be good to check `--require-cet` works as intended if `.note.gnu.property` contains several notes.

 `ld -r` may merge `.note.gnu.property` of several input objects into one. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59780/new/

https://reviews.llvm.org/D59780