[PATCH] D60030: [ELF] Merge LinkerScript::addSymbol and declareSymbol

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 1 00:28:21 PDT 2019


ruiu added a comment.

I'm not sure if this is an improvement. Sometimes, I actually like separating functions even if the separated functions have some amount of common code. It's like writing documents in a natural language -- sometimes you want to repeat the same thing in two different paragraphs to make it easier to understand. It feels to me that this is that kind of situation.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60030/new/

https://reviews.llvm.org/D60030





More information about the llvm-commits mailing list