[PATCH] D59966: [MemorySSA] Don't optimize incomplete phis.

George Burgess IV via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 29 11:31:50 PDT 2019


george.burgess.iv added a comment.

Thanks for this!



================
Comment at: lib/Analysis/MemorySSAUpdater.cpp:315
+          NewInsertedPHIs.push_back(MPhi);
+          NonOptPhis.insert(MPhi);
+        }
----------------
Should these be removed from `NonOptPhis` at some point later (e.g., around line 326)? Or is that done for us elsewhere?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59966/new/

https://reviews.llvm.org/D59966





More information about the llvm-commits mailing list