[PATCH] D59946: [llvm-readobj] Improve error message for for --string-dump

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 29 04:33:07 PDT 2019


grimar accepted this revision.
grimar added a comment.

LGTM with a nit.



================
Comment at: llvm/tools/llvm-readobj/llvm-readobj.cpp:382
+                    reportError(EI.message());
+                  });
 }
----------------
The code is still different from original, why?
(I am not against this renaming, but ideally, such things should be done in an NFC commits I think.)
So if there are no reasons for that, please revert.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59946/new/

https://reviews.llvm.org/D59946





More information about the llvm-commits mailing list