[PATCH] D59951: [NFC][llvm-exegesis] Refactor Analysis::SchedClassCluster::measurementsMatch()

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 29 03:53:51 PDT 2019


courbet accepted this revision.
courbet added a comment.
This revision is now accepted and ready to land.

Thanks Roman.

> This isn't 100% a NFC, because previously for inverse throughput we used `min()`. I have asked whether i have done that correctly in

https://reviews.llvm.org/D57647?id=184939#inline-510384 but did not hear back. I think `avg()` should be used too, thus it is a fix.

It should not matter if we assume that the output from the `NumIterations` measurements is accurate enough, so that's fine.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59951/new/

https://reviews.llvm.org/D59951





More information about the llvm-commits mailing list