[PATCH] D59946: [llvm-readobj] Improve error message for for --string-dump

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/basic.test:3-4
 RUN: not llvm-readobj %t.blah 2>&1 | FileCheck --check-prefix=ENOENT %s
-ENOENT: {{.*}}.blah: {{[Nn]}}o such file or directory
+ENOENT: '{{.*}}.blah': {{[Nn]}}o such file or directory
 
 # Test case where input file is too small to be a recognised object file.
----------------
It is strange to me to see the quotes wrapping the file name here.
I think tools usually do not do that?


================
Comment at: llvm/tools/llvm-readobj/llvm-readobj.cpp:378
 
-void error(Error EC) {
-  if (!EC)
+void error(Error Err) {
+  if (!Err)
----------------
You renamed `EC`->`Err` here, but the code below still use `EC` and this renaming
does not seem necessary (it looks as NFC). Not sure why it was done?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59946/new/

https://reviews.llvm.org/D59946