[PATCH] D59982: [ELF] Rename SyntheticSection::empty to more appropriate needed() with opposite meaning

Fri Mar 29 02:24:03 PDT 2019

MaskRay added a comment.

In D59982#1447386 <https://reviews.llvm.org/D59982#1447386>, @grimar wrote:

> I think renaming makes sense.
>  I also can imagine a different wording in this renaming: `empty()` -> `used()`.
>  Not sure what is better though.

I did struggle with the choice between `used()` and `needed()` :) I chose `needed()` as I think //needed// is slightly stronger: //used// in a way that requires it to exist. As a non-native English speaker my interpretation may be inaccurate and I am open to other suggestions :)

Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59982/new/

https://reviews.llvm.org/D59982