[PATCH] D59080: Merge of global constants does not happen when constants have common linkage

[Eli Friedman via Phabricator via llvm-commits]

efriedma requested changes to this revision.
efriedma added a comment.
This revision now requires changes to proceed.

This isn't correct; GlobalMerge is not legal for symbols with weak linkage, and there isn't any way to correctly emit an alias with "common" linkage in ELF.

(If you want to avoid common linkage for C code, you can build with -fno-common; this is probably a good idea for codebases which are compatible with it.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59080/new/

https://reviews.llvm.org/D59080