[PATCH] D59910: [GlobalISel][AArch64] Add instruction selection support for G_INSERT_VECTOR_ELT on v2s32s

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 28 10:30:57 PDT 2019


paquette marked an inline comment as done.
paquette added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstructionSelector.cpp:2624
+    // No widening needed.
+    InsMI->getOperand(0).setReg(DstReg);
+    constrainSelectedInstRegOperands(*InsMI, TII, TRI, RBI);
----------------
aemerson wrote:
> Why do we now need this for the 128b case?
The lane insert takes in a None as the destination, so we need to set it manually.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59910/new/

https://reviews.llvm.org/D59910





More information about the llvm-commits mailing list