[PATCH] D59431: [DebugInfo] Terminate constant-value location-list ranges at the end of basic blocks

[David Stenberg via Phabricator via llvm-commits]

dstenb added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp:205
   RegDescribedVarsMap RegVars;
+  SmallSet<InlinedEntity, 8> NonRegVars;
   for (const auto &MBB : *MF) {
----------------
Just as a small heads up, I uploaded D59941 and D59942 which aims to improve handling of fragments in DbgEntityHistoryCalculator and its users. If people think that the structure that those patches introduces is a good idea, then it should be possible to adapt this patch to that by using the `LiveEntries` map, which keeps indices for all currently open debug values. That way we can ensure that all open non-overlapping fragments are closed at the end of the basic block.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59431/new/

https://reviews.llvm.org/D59431