[PATCH] D59931: [llvm-readobj] Change variable names to match LLVM-style

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 28 09:07:40 PDT 2019


jhenderson added a comment.

LGTM, with the change in name of one of the variables as suggested inline.



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:232
+  const Elf_Shdr *SymbolVersionSection = nullptr;   // .gnu.version
+  const Elf_Shdr *SymbolVersionRefSection = nullptr; // .gnu.version_r
+  const Elf_Shdr *SymbolVersionDefSection = nullptr; // .gnu.version_d
----------------
Ref -> Need, to match the type.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59931/new/

https://reviews.llvm.org/D59931





More information about the llvm-commits mailing list