[PATCH] D59939: [DebugInfo] Rename DbgValueHistoryMap::{InstrRange -> Entry}, NFC

David Stenberg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 28 08:42:06 PDT 2019


dstenb created this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
dstenb added a parent revision: D59938: [DebugInfo] Make InstrRange into a class, NFC.

In an upcoming commit the history map will be changed so that it
contains explicit entries for instructions that clobber preceding debug
values, rather than Begin- End range pairs, so generalize the name to
"Entry".

Also, prefix the iterator variable names in buildLocationList() with
"E". In an upcoming commit the entry will have query functions such as
"isD(e)b(u)gValue", which could at a glance make one confuse it for
iterations over MachineInstrs, so make the iterator names a bit more
distinct to avoid that.


Repository:
  rL LLVM

https://reviews.llvm.org/D59939

Files:
  include/llvm/CodeGen/DbgEntityHistoryCalculator.h
  lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
  lib/CodeGen/AsmPrinter/CodeViewDebug.h
  lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp
  lib/CodeGen/AsmPrinter/DebugHandlerBase.cpp
  lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  lib/CodeGen/AsmPrinter/DwarfDebug.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59939.192644.patch
Type: text/x-patch
Size: 15493 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190328/6650c464/attachment.bin>


More information about the llvm-commits mailing list