[PATCH] D59687: [DebugInfo] Prologue inserter need to insert DW_OP_deref_size

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 28 04:12:00 PDT 2019


probinson added a comment.

Aside from one style nit, I'm okay with this if Adrian is.



================
Comment at: lib/CodeGen/PrologEpilogInserter.cpp:1148
+        unsigned FrameIdx = MI.getOperand(0).getIndex();
+        unsigned Size = MFI.getObjectSize(FrameIdx);
+
----------------
This is the only use of MFI? I don't see any others...
If so, don't bother with a local variable MFI.

I know it's really picky... it's a fuzzy line, at what point do chains of calls like `MF.getFrameInfo().getObjectSize(FrameIdx)` become too unwieldy, but I think in this case it isn't.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59687/new/

https://reviews.llvm.org/D59687





More information about the llvm-commits mailing list