[PATCH] D59311: [ELF] Dump symbols ordered by profiled guided section layout to file.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/ELF/Driver.cpp:1475
     error("cannot open map file " + Config->MapFile + ": " + E.message());
+  // Fail early too if the symbol order file is not writable
+  if (auto E = tryCreateFile(Config->PrintSymbolOrder))
----------------
Bigcheese wrote:
> ruiu wrote:
> > I don't think we need this guard, as this is a minor feature. Can you remove this code?
> Why not be consistent here?
We could have many more features that writes something to a file, but I don't want to add two lines of code every time we add such feature. I'd remove MapFile rather than adding all files here if it needs to be consistent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59311/new/

https://reviews.llvm.org/D59311