[PATCH] D59749: [ConstantRange] Fix isWrappedSet()

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 27 14:39:59 PDT 2019


lebedev.ri added a comment.

In D59749#1445032 <https://reviews.llvm.org/D59749#1445032>, @nikic wrote:

> After applying the other changes in rL357039 <https://reviews.llvm.org/rL357039>, rL357107 <https://reviews.llvm.org/rL357107> and rL357112 <https://reviews.llvm.org/rL357112>


Thanks!
Those three small diffs are oh so much better than this huge monolithic patch.

> there isn't really much left here. Could change one or two uses of isUpperWrapped() back to isWrappedSet() because it is the same in the used context...

That sounds like a good cleanup to me, if you feel like it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59749/new/

https://reviews.llvm.org/D59749





More information about the llvm-commits mailing list