[PATCH] D59727: [libc++] Fix return value of snprintf_l() on Windows when buffer is too small

Tom Anderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 27 11:09:51 PDT 2019


thomasanderson added a comment.

In D59727#1444886 <https://reviews.llvm.org/D59727#1444886>, @zoecarver wrote:

> Will D59572 <https://reviews.llvm.org/D59572> fix the `__libcpp_locale_guard ` performance issues?


It improves the issue, but does not fix it.  The slowness is caused by setlocale(), and that change reduces the number of calls to setlocale() from 10 to 2.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59727/new/

https://reviews.llvm.org/D59727





More information about the llvm-commits mailing list