[PATCH] D59729: [GVN] non-functional code movement

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 26 18:02:29 PDT 2019


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/one required change.



================
Comment at: lib/Transforms/Utils/VNCoercion.cpp:314
+  if (!GV || !GV->isConstant() || !GV->hasDefinitiveInitializer())
     return -1;
 
----------------
Remove this line, not NFC


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59729/new/

https://reviews.llvm.org/D59729





More information about the llvm-commits mailing list