[PATCH] D59785: [TargetLowering] Change getOptimalMemOpType to take a Function instead of a MachineFunction

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 26 15:07:08 PDT 2019


fhahn added a comment.

I glanced over the implementations and it seems like they only use the function to check its attributes. If that's the case, IMO we should just pass that in as a flag (or just the attributes), rather than unnecessarily passing in the function (requiring access to the function seems a bit odd to me, just to get the memory operation type)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59785/new/

https://reviews.llvm.org/D59785





More information about the llvm-commits mailing list