[PATCH] D59480: [NFC] Add SchedState to allow forwarding the Scheduling state between MBB

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 26 14:58:35 PDT 2019


fhahn added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineScheduler.cpp:1853
 
+void SchedState::reset() {
+  CurrCycle = 0;
----------------
steven.zhang wrote:
> fhahn wrote:
> > Personally, I think it would be simpler to have the constructor create a 'resetted' object. In SchedBoundary::reset(), we then can either assign a 'resetted' object or a user provided one.
> Sounds good. I will leave the way how to reset/save/store the state into next NFC infrastructure patch if this one is accepted.
I think it would be helpful if you could post your follow-up patches on Phabricator as well, and link them. That would make it easier to see the full picture.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59480/new/

https://reviews.llvm.org/D59480





More information about the llvm-commits mailing list