[PATCH] D59822: [DAGCombiner] Don't allow addcarry if the type of the carry producer is illegal.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 26 11:45:59 PDT 2019


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: test/CodeGen/SystemZ/dag-combine-05.ll:9-10
+
+; CHECK-NOT: addcarry
+; CHECK-NOT: LLVM ERROR: Cannot select: {{.*}} = SystemZISD::GET_CCMASK
+
----------------
It's better to use positive CHECK lines so we know the result is correct rather than only 'not wrong'.
'utils/update_llc_test_checks.py' should be fine to use here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59822/new/

https://reviews.llvm.org/D59822





More information about the llvm-commits mailing list