[PATCH] D59816: [Support] Implement zlib independent crc32 computation

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 26 08:58:31 PDT 2019


aprantl added inline comments.


================
Comment at: lib/Support/CMakeLists.txt:78
   CommandLine.cpp
   Compression.cpp
+  CRC.cpp
----------------
Shouldn't this be only conditionally compiled if zlib isn't available? It seems wrong to have the lookup table twice.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59816/new/

https://reviews.llvm.org/D59816





More information about the llvm-commits mailing list