[PATCH] D59816: [Support] Implement zlib independent crc32 computation

Joerg Sonnenberger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 26 06:19:25 PDT 2019


joerg added a comment.

I'd recomment copying the version from libarchive (https://github.com/libarchive/libarchive/blob/master/libarchive/archive_crc32.h):

- don't bother with the 1KB table in both binary and source, just recompute it on the first use.
- at least in the past unrolling the inner loop somewhat helped a lot

I wouldn't really fuzz test this, just build a set of test vector and be done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59816/new/

https://reviews.llvm.org/D59816





More information about the llvm-commits mailing list