[PATCH] D59713: [ARM] Add missing memory operands to a bunch of instructions.

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 26 06:08:11 PDT 2019


peter.smith added a comment.

> It does not appear to be showing up on our Arm v8 builders clang-cmake-armv8-selfhost-neon , and I've not yet been able to reproduce that on a v8 machine. One difference is that the v7 builders use gcc 5.4 for stage-1 whereas I think the v8 builders use clang. I will try and reproduce with gcc 5.4.0 on a v8 machine.

I've been able to reproduce the buildbot failure on an x86 machine. It requires --target=armv7a-linux-gnueabihf -mcpu=cortex-a15 on CodeGen/GlobalISel/Utils.cpp. On our v8 builder -mcpu=cortex-a57 is used so this is why we didn't see the crash. From a build directory alongside LLVM

  clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -D_LARGEFILE_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/CodeGen/GlobalISel -I../llvm/lib/CodeGen/GlobalISel -Iinclude -I../llvm/include --target=armv7a-linux-gnueabihf -mcpu=cortex-a15 -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -std=c++11 -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -UNDEBUG -fno-exceptions -fno-rtti -MMD -MT lib/CodeGen/GlobalISel/CMakeFiles/LLVMGlobalISel.dir/Utils.cpp.o -MF lib/CodeGen/GlobalISel/CMakeFiles/LLVMGlobalISel.dir/Utils.cpp.o.d -o lib/CodeGen/GlobalISel/CMakeFiles/LLVMGlobalISel.dir/Utils.cpp.o -c ../llvm/lib/CodeGen/GlobalISel/Utils.cpp

The reproducer in the PR is much shorter though.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59713/new/

https://reviews.llvm.org/D59713





More information about the llvm-commits mailing list