[PATCH] D59687: [DebugInfo] Prologue inserter need to insert DW_OP_deref_size

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

Thanks for the detailed explanation.  The deref_size is clearly necessary in this example.
Most DWARF expressions are location expressions, not value expressions, so most deref operations are actually fetching an address. As we start doing more with salvaging values from optimizations, we might find ourselves doing more value expressions, so it's worth keeping an eye out for those.  The call-site parameter stuff might be a place to think about in those terms.

@aprantl @dblaikie it bugs me that MIParser and LLParser each have their own DIExpression parser.  As this patch shows, they can get out of sync. Is it worth trying to do something about that?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59687/new/

https://reviews.llvm.org/D59687