[PATCH] D59780: Support Intel Control-flow Enforcement Technology

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added inline comments.


================
Comment at: lld/ELF/Arch/X86_64.cpp:209-210
+    write32le(Buf + 5, I * sizeof(object::ELF64LE::Rela));
+    write32le(Buf + 10, -getPltEntryOffset(I) - 14);
+    Buf += sizeof(Inst);
+  }
----------------
It seems will always write the same place.


================
Comment at: lld/test/ELF/Inputs/x86-64-cet4.s:3
+.long 4
+.long 16
+.long 5
----------------
This should not be fixed if used for 32-bit tests.
The standard style should be:

```
 .p2align x
 .long 4
 .long 4f -1f
 .long 5
...
1:
 .....
.p2align x
4:
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59780/new/

https://reviews.llvm.org/D59780