[PATCH] D59635: [AArch64] NFC: Cleanup isAArch64FrameOffsetLegal

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/Target/AArch64/AArch64InstrInfo.cpp:3269
+    NewOffset = NewOffset < 0 ? MinOff : MaxOff;
+    Offset = Offset - NewOffset * Scale + Remainder;
   }
----------------
It's still a little strange to compute "Offset" here, then only use the computed value to check whether it's equal to zero.  A separate variable probably makes more sense.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59635/new/

https://reviews.llvm.org/D59635