[PATCH] D59763: [llvm-objcopy] - Strip sections before symbols.

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 25 12:01:01 PDT 2019


alexshap added inline comments.


================
Comment at: tools/llvm-objcopy/ELF/ELFObjcopy.cpp:545
 
-  if (Error E = updateAndRemoveSymbols(Config, Obj))
+  if (Error E = replaceAndRemoveSections(Config, Obj))
     return E;
----------------
I think it's worth adding a comment here explaining that the order is really important here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59763/new/

https://reviews.llvm.org/D59763





More information about the llvm-commits mailing list