[PATCH] D57694: [DebugInfo][DAG] Either salvage dangling debug info or emit Undef DBG_VALUEs

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 25 09:01:41 PDT 2019


probinson added a comment.

In D57694#1441561 <https://reviews.llvm.org/D57694#1441561>, @jmorse wrote:

> In D57694#1441530 <https://reviews.llvm.org/D57694#1441530>, @srhines wrote:
>
> > Switching it to a MapVector makes it deterministic. I was just struggling late last night to try to reduce the .ll file down to something worth checking in! If you want to take over to minimize the test case, that would be much appreciated. Let me know so I can continue doing that if needed. Thanks.
>
>
> Hmm, what kind of requirements are there for tests for nondeterminism? Just a high probability of triggering the existing fault/variation? This is interesting as unreliable compilation presumably means the test can't be reliable either.


First thing I'd try is the reverse-iteration stuff.  If you can get an existing test to fail reliably with that, you're done.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57694/new/

https://reviews.llvm.org/D57694





More information about the llvm-commits mailing list