[PATCH] D59186: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU style`

Xing via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 22 16:44:08 PDT 2019


Higuoxing added a comment.

In D59186#1440097 <https://reviews.llvm.org/D59186#1440097>, @RKSimon wrote:

> In D59186#1440082 <https://reviews.llvm.org/D59186#1440082>, @RKSimon wrote:
>
> > In D59186#1439653 <https://reviews.llvm.org/D59186#1439653>, @Higuoxing wrote:
> >
> > > Oops, I made a mistake in this patch, so I reverted the change. I'm sorry.
> >
> >
> >
> >
> >   @Higuoxing The reversion doesn't appear to have been committed 
>
>
> It looks like you only reverted ElfDumper.cpp at rL356777 <https://reviews.llvm.org/rL356777> - @dyung reverted the tests at rL356811 <https://reviews.llvm.org/rL356811>


I am sorry, after reverting the change, I went to sleep last night ... I should have double checked this change.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59186/new/

https://reviews.llvm.org/D59186





More information about the llvm-commits mailing list